Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PlaceSimpleBeacon and AnimatedBeacon into PlaceBeacon and Beacon #16006

Merged
merged 3 commits into from Mar 14, 2019
Merged

Merge PlaceSimpleBeacon and AnimatedBeacon into PlaceBeacon and Beacon #16006

merged 3 commits into from Mar 14, 2019

Conversation

abcdefg30
Copy link
Member

Closes #15778 (kind of).
Prerequisite for taking the rest of #15785.

Thoughts for a follow-up PR: Would it make sense to empty the defaults for ArrowSequence and CircleSequence?

@abcdefg30 abcdefg30 mentioned this pull request Jan 5, 2019
Merged
@pchote
Copy link
Member

pchote commented Jan 5, 2019

Thoughts for a follow-up PR: Would it make sense to empty the defaults for ArrowSequence and CircleSequence?

Yes

pchote
pchote reviewed Mar 9, 2019
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, otherwise looks reasonable. Needs a rebase too.

OpenRA.Mods.Common/Effects/Beacon.cs Show resolved Hide resolved
@abcdefg30
Copy link
Member Author

Rebased.

pchote
pchote approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@abcdefg30
Copy link
Member Author

Rebased and updated.

@reaperrr reaperrr merged commit e2a5167 into OpenRA:bleed Mar 14, 2019
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/4a34cf09216ca5e809598ed8273e38f3a7d23021...80fca0abdfee2e34cf272f23a52551de29f44aa8

@abcdefg30 abcdefg30 deleted the uniBeacon branch March 14, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchote pchote pchote approved these changes

@reaperrr reaperrr reaperrr approved these changes

Assignees
No one assigned
Labels
PR: Is Dependency PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abcdefg30 @pchote @reaperrr