Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PlaceSimpleBeacon and AnimatedBeacon into PlaceBeacon and Beacon #16006

Merged
merged 3 commits into from Mar 14, 2019

Conversation

@abcdefg30
Copy link
Member

commented Jan 5, 2019

Closes #15778 (kind of).
Prerequisite for taking the rest of #15785.

Thoughts for a follow-up PR: Would it make sense to empty the defaults for ArrowSequence and CircleSequence?

@pchote

This comment has been minimized.

Copy link
Member

commented Jan 5, 2019

Thoughts for a follow-up PR: Would it make sense to empty the defaults for ArrowSequence and CircleSequence?

Yes

@pchote
Copy link
Member

left a comment

Just one comment, otherwise looks reasonable. Needs a rebase too.

OpenRA.Mods.Common/Effects/Beacon.cs Show resolved Hide resolved
@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Rebased.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:uniBeacon branch from 532a5cf to e683cf8 Mar 11, 2019

@pchote
pchote approved these changes Mar 11, 2019
Copy link
Member

left a comment

LGTM otherwise

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Rebased and updated.

@pchote pchote added the PR: Needs +2 label Mar 11, 2019

@reaperrr reaperrr merged commit e2a5167 into OpenRA:bleed Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:uniBeacon branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.