New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut for Copy in Map editor #16008

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
3 participants
@rob-v
Copy link
Contributor

rob-v commented Jan 5, 2019

Add Ctrl+C shortcut for Copy in Map editor
(Grid already has F1 key)

Closes #14723

@pchote pchote added this to the Next Release milestone Jan 8, 2019

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 19, 2019

I found two issues while testing this:

  • The Copy/Paste button is missing the tooltip which shows the shortcut
  • The shortcut needs to be Cmd + C to match platform conventions on macOS.
@rob-v

This comment has been minimized.

Copy link
Contributor Author

rob-v commented Jan 19, 2019

'Cmd' is never used in a .yaml and I couldn't get it working on Windows. We use also elsewhere 'Ctrl'. Can I keep Ctrl or what should I do?

@rob-v rob-v force-pushed the rob-v:MapEditorShortcuts branch from c5736d1 to 2761bab Jan 19, 2019

@rob-v

This comment has been minimized.

Copy link
Contributor Author

rob-v commented Jan 19, 2019

Updated - added tooltip for Copy and Zoom.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 19, 2019

'Cmd' is never used in a .yaml and I couldn't get it working on Windows. We use also elsewhere 'Ctrl'. > Can I keep Ctrl or what should I do?

The modifier is called Meta internally - find references to see the other cases where we special-case CtrlCmd.

See 719c747 for IMO the best short-term approach.
Fixing this properly is going to be a much bigger job.

@pchote

pchote approved these changes Jan 19, 2019

Copy link
Member

pchote left a comment

LGTM, but best to wait for another @OpenRA/engine-hackers to approve my hotkey hack before merging.

@pchote pchote merged commit 9025d11 into OpenRA:bleed Jan 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment