Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay support to NukeLaunch projectile effect #16013

Merged
merged 2 commits into from Mar 9, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Jan 6, 2019

And use that to remove the remaining DelayedAction from NukePower.

Add delay support to NukeLaunch
And use that to remove the remaining DelayedAction from NukePower.

@reaperrr reaperrr changed the title Add delay support to NukeLaunch Add delay support to NukeLaunch effect Mar 3, 2019

@reaperrr reaperrr changed the title Add delay support to NukeLaunch effect Add delay support to NukeLaunch projectile effect Mar 3, 2019

@pchote
Copy link
Member

left a comment

LGTM, but testing this reveals an existing bug with the D2k mod rules: the death hand missile vanishes for one tick between the launch-prep and launched animations. Would you mind fixing that here?

Fix D2k Death Hand launch transition
Missile would otherwise visually disappear for a tick.
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

Updated.

@pchote
pchote approved these changes Mar 9, 2019

@pchote pchote merged commit d7f8f2b into OpenRA:bleed Mar 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:nukelaunch-delay branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.