Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of EnemyWatcher and AnnounceOnSeen #16029

Merged
merged 3 commits into from Feb 22, 2019

Conversation

@abcdefg30
Copy link
Member

commented Jan 7, 2019

Also fixes the descriptions for On(Player)Discovered in the Lua API.

EnemyWatcher loops over World.ActorsWithTrait<AnnounceOnSeen>, so AnnounceOnSeen is a must for any of the methods to work.

@obrakmann
Copy link
Contributor

left a comment

👍 I think those commits could well be squashed together, though.

@reaperrr
Copy link
Contributor

left a comment

I think those commits could well be squashed together, though.

While I agree, I feel neither like waiting nor like updating the PR myself, so lgtm.

@reaperrr reaperrr merged commit 7c2f8ef into OpenRA:bleed Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:docAnnounce branch Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.