New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cash tick volume #16034

Merged
merged 2 commits into from Jan 27, 2019

Conversation

Projects
None yet
6 participants
@pchote
Copy link
Member

pchote commented Jan 7, 2019

This PR adds the ability to define volume modifiers on individual notifications, and uses this to make the cash ticks a bit less prominent (and balance out the up/down volume mismatch in TD).

This is pretty simple polish, so i'm not sure whether we want to sneak this in for the next playtest or defer it to next + 1.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Jan 8, 2019

I would like it if these modifiers could be set in the game settings and their values be applied to notifications that have the modifier trait. For example, instead of adding a generic VolumeModifier, add a ChatNotificationVolumeModifier and GameNotificationVolumeModifier (and others that can be used for a group of notifications.)

Or, allow to define a modifier per notification in a NotificationVolumeModifier trait and bind that definition and a value to some sort of NotificationVolumeManager.

@jaZzKCS

This comment has been minimized.

Copy link
Contributor

jaZzKCS commented Jan 26, 2019

There are a variety of sounds that are still standing out in comparison to their companions (example being the money up/down sounds in Tiberian Dawn) which I would love to see fixed via this matter. All in all this would give over a much more polished vibe regarding the whole project. These things are small but important.

The money ticks themselves being a nuisance or not is not widely debated, as the last attempt of fixing them (which resulted in the mute-option as we have it today) gave players that were annoyed by it (which is directly connected to it's volume most of the times) the chance to turn it off, whereas the vast majority simply doesn't care.

If it leads to more people not being inclined to turn it off because of it being too loud, then I am all for this fix.

@netnazgul

This comment has been minimized.

Copy link
Contributor

netnazgul commented Jan 26, 2019

ok, I gave it a quick test. I'd say for me it makes little difference, I'm comfortable with both. So for those who have it disabled it will make no difference at all (obviously), and it will comfort the all-too-loud sounds into bearable zone. So subjectively I'm up for the fix.

Also, if I get it right, people will be able to modify other notification sounds volume via [simple enough] yaml modification.

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 26, 2019

(example being the money up/down sounds in Tiberian Dawn)

Fixed in this PR.

@pchote pchote added this to the Next Release milestone Jan 26, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 27, 2019

This integrates nicely with the other sidebar sound fixes, and generated some good discussion on discord - so adding to the milestone.

@pchote pchote added the PR: Needs +2 label Jan 27, 2019

@reaperrr reaperrr merged commit 518a54a into OpenRA:bleed Jan 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment