New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsDead check to fix crash in Sarin Gas 1 #16035

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
4 participants
@Smittytron
Copy link
Contributor

Smittytron commented Jan 8, 2019

Closes #16032

@MustaphaTR

This comment has been minimized.

Copy link
Member

MustaphaTR commented Jan 8, 2019

I think we don't need the else, and is against the code standards we have been using everywere else.

Code should be:

	if mammoth.IsDead then
		return
	end

	mammoth.Patrol(MammothPath, true, 20)
@abcdefg30

This comment has been minimized.

Copy link
Member

abcdefg30 commented Jan 8, 2019

if not mammoth.IsDead then
	mammoth.Patrol(MammothPath, true, 20)
end

would be even better, imo.

@pchote pchote added this to the Next Release milestone Jan 8, 2019

@Smittytron Smittytron force-pushed the Smittytron:IsDead-Sarin1 branch from aaaf72d to 03ed339 Jan 9, 2019

@Smittytron

This comment has been minimized.

Copy link
Contributor Author

Smittytron commented Jan 9, 2019

Updated

@pchote

pchote approved these changes Jan 19, 2019

Copy link
Member

pchote left a comment

Fix confirmed

@pchote pchote merged commit da40f45 into OpenRA:bleed Jan 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Smittytron Smittytron deleted the Smittytron:IsDead-Sarin1 branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment