New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warhead.IsValidAgainst crash #16051

Merged
merged 1 commit into from Jan 19, 2019

Conversation

Projects
None yet
2 participants
@rob-v
Copy link
Contributor

rob-v commented Jan 10, 2019

It happened for FrozenActors - victim.Owner == null so no stance. If it can't happen for Actor, we could use victim.IsValid check instead of Owner or keep Owner as more explicit here.

Fixes #16019

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 10, 2019

Thanks for debugging this!

If it can't happen for Actor, we could use victim.IsValid check instead of Owner or keep Owner as more explicit here.

These were going to be exactly my review comments, so please do drop the actor check and use IsValid for FrozenActor. Context: FrozenActor uses Owner == null as a magic value to denote that the frozen actor has been invalidated. Owners can otherwise never be null.

@rob-v rob-v force-pushed the rob-v:FixWarheadIsValidAgainst branch from c140cd6 to b0d3a0d Jan 10, 2019

@rob-v

This comment has been minimized.

Copy link
Contributor Author

rob-v commented Jan 10, 2019

Updated.

@pchote pchote added this to the Next Release milestone Jan 10, 2019

@pchote

pchote approved these changes Jan 19, 2019

@pchote pchote merged commit 9ed2ffe into OpenRA:bleed Jan 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment