New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #7083: Fly stops turning when target is inside the turn radius #16054

merged 1 commit into from Feb 8, 2019


None yet
4 participants
Copy link

portablestew commented Jan 12, 2019

Calculate when the target point is within the aircraft's turn radius. In this case, the destination cannot be reached by simply turning, so fly away until it becomes reachable.

This situation was very reproducible, by shift-clicking some move waypoints for a Yak: first two adjacent cells, and then a third one anywhere else. The Yak flies to the first waypoint, but then is stuck circling the second one because its turn isn't sharp enough to ever reach it.

I initially encountered AI yaks getting stuck in this way while playing the Allied campaign (mainly noticed on allies-06b). However, it does appear to solve the latest issue described in #7083.

@portablestew portablestew force-pushed the portablestew:aircraftTurnRadius branch from 6ae97ca to 2eec69b Jan 31, 2019

@portablestew portablestew force-pushed the portablestew:aircraftTurnRadius branch from 2eec69b to f18b3ce Jan 31, 2019


pchote approved these changes Feb 7, 2019

Copy link

pchote left a comment

Code changes look reasonable, and confirmed that this fixes the bug.

@pchote pchote added the PR: Needs +2 label Feb 7, 2019


This comment has been minimized.

Copy link

pchote commented Feb 7, 2019

This fits in well with the targeting and other aircraft fixes, so lets try and get this in for the playtest.

@pchote pchote added this to the Next Release milestone Feb 7, 2019

Copy link

matjaeck left a comment

Rebased for testing onto current bleed, fix works.

@reaperrr reaperrr merged commit 2d4bad6 into OpenRA:bleed Feb 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@portablestew portablestew deleted the portablestew:aircraftTurnRadius branch Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment