Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deploy orders on units with the Cargo trait to be queued #16060

Merged
merged 1 commit into from Mar 13, 2019

Conversation

@tovl
Copy link
Contributor

commented Jan 12, 2019

In response to issue #16026.
This extends the functionality which now exists to queue deploy orders for units with the Transform trait (such as MCVs) to units with the Cargo trait (APC, Chinook, etc.).

Fixes #4774.

@Smittytron

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2019

Can you squash fix-up commits?

make cargo unload deploy action queueable
fix line spacing

remove unnecessary null check

@tovl tovl force-pushed the tovl:queue-unload branch from 9436c91 to dc6c1ab Jan 13, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

Okay. squashed the commits.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

Since PR #16065 is flagged for next release, shouldn't this one be as well?

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

This should also fix #4774.

@matjaeck matjaeck referenced this pull request Jan 28, 2019

@pchote pchote added this to the Next + 1 milestone Mar 10, 2019

@reaperrr reaperrr merged commit 9f419fc into OpenRA:bleed Mar 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.