Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple enumeration of validCells in SpawnMPUnits #16064

Merged
merged 1 commit into from Feb 18, 2019

Conversation

@teinarss
Copy link
Contributor

commented Jan 15, 2019

Just a small fix which I discovered during debugging of the Locomotor Cache PR. This will prevent that validcells expression will be evaluated one extra time.

@teinarss teinarss force-pushed the teinarss:dont_enumerate_twice branch 2 times, most recently from 7c5731e to c63e511 Jan 15, 2019

@abcdefg30
Copy link
Member

left a comment

Looks good to me otherwise. 👍 /

@teinarss teinarss force-pushed the teinarss:dont_enumerate_twice branch from c63e511 to 6881175 Feb 14, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

Done!

@teinarss teinarss force-pushed the teinarss:dont_enumerate_twice branch from 6881175 to 51ab2ec Feb 14, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@teinarss Looks like the empty line between var validCell and the if check is still there.

@teinarss

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2019

I kept that empty line because in my humble opinion it makes the code a bit more readable .

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

I kept that empty line because in my humble opinion it makes the code a bit more readable.

After looking at the raw file without diff highlighting, I agree.

@reaperrr reaperrr merged commit be741ce into OpenRA:bleed Feb 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.