New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework production palette audio feedback. #16083

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
5 participants
@pchote
Copy link
Member

pchote commented Jan 19, 2019

Fixes #16033 by copying what RA2 does.

@pchote pchote added this to the Next Release milestone Jan 19, 2019

@pchote pchote added the PR: Needs +2 label Jan 20, 2019

@pchote pchote dismissed stale reviews from TheChosenEvilOne and Smittytron via bb1bcd5 Jan 22, 2019

@pchote pchote force-pushed the pchote:production-audio-notifications branch from 5d7b625 to bb1bcd5 Jan 22, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Jan 22, 2019

Rebased, and replaced the nulls in the PlayNotification calls with World.LocalPlayer for consistency with the rest of the file (it makes no difference in the Sound code).

@@ -267,14 +267,15 @@ bool HandleLeftClick(ProductionItem item, ProductionIcon icon, int handleCount,
{
if (PickUpCompletedBuildingIcon(icon, item))
{
Game.Sound.Play(SoundType.UI, TabClick);
Game.Sound.PlayNotification(World.Map.Rules, World.LocalPlayer, "Sounds", ClickSound, null);

This comment has been minimized.

@teinarss

teinarss Jan 24, 2019

Contributor

Maybe convert the "Sounds" to a const and use it on all the places

This comment has been minimized.

@pchote

pchote Jan 24, 2019

Author Member

"Sounds" is used across 17 files, so would rather not do that in this PR

@pchote pchote merged commit 64c853a into OpenRA:bleed Jan 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment