New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash by chat commands in replay #16085

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@rob-v
Copy link
Contributor

rob-v commented Jan 20, 2019

In replay LocalClient can be null or different player than player viewing replay and using chat command.
For replay use null as player name for chat commands, it isn't used so far anyway.

Fixes #16046

@pchote pchote added this to the Next Release milestone Jan 20, 2019

@rob-v rob-v force-pushed the rob-v:FixReplayChatCommands branch from f07809c to c47cf32 Jan 20, 2019

@pchote

pchote approved these changes Jan 22, 2019

@pchote pchote merged commit a2c6b19 into OpenRA:bleed Jan 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment