Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Building/UnitDelays and make D2k AI wait to upgrade ConYard #16091

Merged
merged 2 commits into from Mar 14, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Jan 21, 2019

Closes #16087

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

I guess we could take this first, but I think it would be more ideal to do #16180 first (at least the refactor of BuildingFractions/Limits) and make this another sub-property.
Pinging @pchote for opinion.

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Pinging @pchote for opinion.

@abcdefg30
Copy link
Member

left a comment

Code changes look good however. 👍

@pchote

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

I think it would be more ideal to do #16180 first

I agree that it would be more ideal to wait, but I don't think we have any PRs for that in the pipeline so, pragmatically, I don't think its worthwhile holding up this relatively simple PR for it.

@abcdefg30
Copy link
Member

left a comment

Looks good to me. Note that priority overwrites (power, refineries) are not affected by this.

@reaperrr reaperrr merged commit 8edbf66 into OpenRA:bleed Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:ai-production-delay branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.