New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AttackSuicides trait (to improve Demo Trucks) #16101

Merged
merged 4 commits into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@pchote
Copy link
Member

pchote commented Jan 23, 2019

The AttackSuicides trait misses a lot of the plumbing needed to do its job properly, and our current known usecases can be solved just as well, if not better, by assembling other traits.

Fixes #16061
Helps towards #12918, #11582, #16048
Fixes the probably long-broken harvester bombs in the drop zone maps

@pchote pchote added this to the Next Release milestone Jan 23, 2019

@matjaeck
Copy link
Contributor

matjaeck left a comment

Demo truck behavior (has now 2cell range / doesn't execute an attack order if it can't get in range) looks good to me.

@pchote pchote force-pushed the pchote:remove-attacksuicides branch from 65430d6 to 54f8212 Jan 23, 2019

@tovl

This comment has been minimized.

Copy link
Contributor

tovl commented Jan 26, 2019

I just tested this in-game. The demo-truck behavior looks fine now. It also works with queued deploy orders. The only thing I noticed is that if the target is unreachable it will not explode but it doesn't drop the target either. If the target, for some reason, becomes reachable again it will continue with the attack. I would expect it to just drop the target entirely. This may be the intended behavior though.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Jan 26, 2019

The only thing I noticed is that if the target is unreachable it will not explode but it doesn't drop the target either. If the target, for some reason, becomes reachable again it will continue with the attack. I would expect it to just drop the target entirely. This may be the intended behavior though.

This is the usual behavior (wall in a tank, give it a target out of range and sell the walls).

@pchote pchote force-pushed the pchote:remove-attacksuicides branch from 54f8212 to b371e8b Jan 27, 2019

@pchote pchote merged commit 810aa74 into OpenRA:bleed Feb 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment