New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engineer and thief to Monster Tank Madness #16128

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@Smittytron
Copy link
Contributor

Smittytron commented Jan 27, 2019

Fixes part of #16127

The original gave the player two engineers and a thief at the start of the mission. Now that we've changed both engineers and thieves it makes sense to match the original here.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 27, 2019

We still have thieves on soviet, so does it really make sense to include them here?

@obrakmann obrakmann added this to the Next Release milestone Jan 27, 2019

@Smittytron

This comment has been minimized.

Copy link
Contributor Author

Smittytron commented Jan 27, 2019

We still have thieves on soviet, so does it really make sense to include them here?

It does to me, but I don't have the same view on keeping missions and multiplayer equal. If you insist we can use 3 engineers here instead.

This issue will come to a head again when we get to missions with helicopters. My opinion is to have hinds on soviets for missions.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 27, 2019

I'm less concerned about Hinds because I'm still convinced that we will eventually find a way to move them back to Soviet in MP too. I won't insist on engineer over thief here if you don't want to do that, so I guess we wait for someone else to chime in with a tiebreaking opinion.

@pchote pchote requested a review from reaperrr Feb 2, 2019

@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Feb 2, 2019

I don't have the same view on keeping missions and multiplayer equal

Me neither, I'm ok with this. However, if we go with the thief, the trigger in

Trigger.OnCapture(USSROutpostSilo, function() -- getting money through capturing doesn't work
player.Cash = player.Cash + Utils.RandomInteger(1200, 1300)
isn't needed anymore and should be removed.

@Smittytron Smittytron force-pushed the Smittytron:add-units-monster-tank-madness branch from 0052732 to c9b481f Feb 3, 2019

@Smittytron

This comment has been minimized.

Copy link
Contributor Author

Smittytron commented Feb 3, 2019

Updated

@obrakmann
Copy link
Contributor

obrakmann left a comment

Alright, that part of the mission works now. However, this does not fix #16127, as another bug seems to prevent the helicopter to fly off the map. I suggest to merge this PR, but keep the issue open.

@reaperrr reaperrr merged commit 1830b3e into OpenRA:bleed Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Smittytron Smittytron deleted the Smittytron:add-units-monster-tank-madness branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment