New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase FlyCircle ticks to 1 when idling #16135

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@tovl
Copy link
Contributor

tovl commented Jan 28, 2019

fixes issue #16134.

FlyCircle would run indefinitely and queued activities don't cancel a running activity, so changed FlyCircle to run 1 tick instead of infinite ticks.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Jan 28, 2019

I'm not a big fan of creating so many throw away activities - how about adding a "cancel if something else is queued" flag to FlyCircle instead?

@tovl tovl force-pushed the tovl:fix-aircraft-idle branch from 4c45c18 to ba587eb Jan 28, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

tovl commented Jan 28, 2019

Done.

@matjaeck
Copy link
Contributor

matjaeck left a comment

This causes a freeze for me when

  • build 1 airfield
  • build 2 yaks
  • order a yak to force fire somewhere, then hit F so it reloads
  • hit F on the other yak

@tovl btw, if you didn't notice, there is an IRC channel at irc://chat.freenode.net/openra where you can talk about your PRs with the devs. you can also join via the web interface at http://webchat.freenode.net/?channels=openra (but you need to register a nickname) :)

@tovl

This comment has been minimized.

Copy link
Contributor Author

tovl commented Jan 28, 2019

Regression is fixed. It seems a line that was intended to prevent an infinite loop, now caused an infinite loop. EDIT: I was mistaken, it was actually the other branch of that if else statement where the infinite loop occurred.

there is an IRC channel

Thanks for the tip!

@matjaeck
Copy link
Contributor

matjaeck left a comment

Regression is fixed. It seems a line that was intended to prevent an infinite loop, now caused an infinite loop.

Unfortunately not :(

It now freezes when you attack something with multiple yaks and issue "F" on all selected yaks (1 airfield).

This will require more changes.

Edit: Your last push didn't fix the first issue, this appears to be the same bug as before.

@tovl tovl force-pushed the tovl:fix-aircraft-idle branch from 0841341 to 64ba861 Jan 29, 2019

@matjaeck
Copy link
Contributor

matjaeck left a comment

64ba861 has fixed #16134 and I can't find other issues here 👍

Edit: Still valid for 850f937.

@pchote pchote requested review from reaperrr and obrakmann Jan 29, 2019

add check for NextActivity to FlyCircle
prevent infinite loop

fix for ReturnToBase

cleanup

@tovl tovl force-pushed the tovl:fix-aircraft-idle branch from 64ba861 to 850f937 Jan 30, 2019

@obrakmann
Copy link
Contributor

obrakmann left a comment

lgtm 👍

@pchote pchote added this to the Next Release milestone Feb 2, 2019

@pchote

pchote approved these changes Feb 3, 2019

@pchote pchote merged commit ee19cb6 into OpenRA:bleed Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment