New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VolumeModifier support to music. #16138

Merged
merged 1 commit into from Feb 2, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Jan 29, 2019

This PR adds the engine support for #14231. I don't have the expansion sound files to test with, so I will leave the yaml changes to @reaperrr of @dan9550.

Note that we cannot reliably boost volume using modifiers > 1, and will instead need to reduce the volume of all tracks, with the noted tracks reduced less.

Quote from the OpenAL 1.1 specification:

AL_GAIN larger than one (i.e. amplification) is permitted for source and listener. However, the implementation is free to clamp the total gain (effective gain per-sourcemultiplied by the listener gain) to one to prevent overflow

On my system VolumeModifiers > 1 appear to make no difference, so it seems that macOS is clamping the total gain to one.

@pchote pchote added this to the Next Release milestone Jan 29, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 2, 2019

Note: I have a follow-up that fixes TD track volumes. Since values > 1.0 won't work for everyone, the other mods aren't worth tackling as there are far less (and far less pronounced) differences between tracks compared to TD.

@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Feb 2, 2019

@obrakmann obrakmann merged commit b71c080 into OpenRA:bleed Feb 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment