New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer target to lastVisible target if it is visible. #16152

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Feb 2, 2019

This PR changes Attack.TickAttack to use the standard checkTarget pattern instead of blindly using lastVisibleTarget even when the primary target is visible.

This should fix #16143 even without having a specific repro case for it.

@pchote pchote added this to the Next Release milestone Feb 2, 2019

@obrakmann
Copy link
Contributor

obrakmann left a comment

Looks reasonable, 👍

@reaperrr reaperrr merged commit 0a57fbd into OpenRA:bleed Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment