New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dead aircraft to no longer be in range in AirstrikePower and ParatroopersPower #16155

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
3 participants
@obrakmann
Copy link
Contributor

obrakmann commented Feb 2, 2019

Fixes #16137

Dead aircraft weren't removed from the aircraftInRange array, so when the last aircraft leaves the range, it still thinks there are aircraft in range and the camera doesn't get removed.

@obrakmann obrakmann added this to the Next Release milestone Feb 2, 2019

@obrakmann obrakmann force-pushed the obrakmann:fix16137_airstrikepower-camera-bug branch from 07a39c7 to e8a1ac8 Feb 2, 2019

@obrakmann obrakmann changed the title Consider dead aircraft to no longer be in range in AirstrikePower Consider dead aircraft to no longer be in range in AirstrikePower and ParatroopersPower Feb 2, 2019

@matjaeck
Copy link
Contributor

matjaeck left a comment

Fix works.

@pchote

pchote approved these changes Feb 3, 2019

Copy link
Member

pchote left a comment

Code change looks sensible

@pchote pchote merged commit 3093f67 into OpenRA:bleed Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@obrakmann obrakmann deleted the obrakmann:fix16137_airstrikepower-camera-bug branch Feb 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment