New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize RA/TD track volumes #16161

Merged
merged 2 commits into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@reaperrr
Copy link
Contributor

reaperrr commented Feb 3, 2019

Fixes #14231 for TD and RA, roughly based on @dan9550's ReplayGain values.

I also went through the D2k and TS tracks by ear, but in my opinion there aren't any outliers in them that justify touching these.

Also manually tested the tracks mentioned in #16140.
The 3 sfx tracks have nearly identical volume to their non-sfx counterparts.
Outtakes has a similar volume, too.

Furthermore, some TD tracks from the original were falsely listed under CovOps.
Only tracks with 226m in their filename are cov ops tracks.

reaperrr added some commits Jan 31, 2019

Normalize TD track volumes and fix order
Some tracks from the original were falsely listed under CovOps.

@reaperrr reaperrr added this to the Next Release milestone Feb 3, 2019

@pchote

pchote approved these changes Feb 3, 2019

Copy link
Member

pchote left a comment

SGTM

@pchote pchote added the PR: Needs +2 label Feb 3, 2019

@obrakmann obrakmann merged commit 297be6d into OpenRA:bleed Feb 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Feb 3, 2019

@dan9550

This comment has been minimized.

Copy link
Contributor

dan9550 commented Feb 3, 2019

Ahh beat me to the rest 😮
If we need to revise this in future let me know I have the process figured out after doing the ra tracks.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

reaperrr commented Feb 3, 2019

Ahh beat me to the rest 😮

Sorry, I wasn't sure if you were working on a PR.
Feel free to file a follow-up if you have some suggestions for polish/fine-tuning the values.

@dan9550

This comment has been minimized.

Copy link
Contributor

dan9550 commented Feb 4, 2019

No worries this is the kind of change that's going to be subjective really. As long as everyone happy with the values we shouldn't have to get too serious with it.

I might take a look at doing the TS, and D2K music at some point if I have the time, as you said we can always fine tune.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment