New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer UpdateFrozenActor until the end of the tick. #16168

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Feb 4, 2019

Fixes #16166.

Defer UpdateFrozenActor until the end of the tick.
Updating the frozen actor calls Actor.GetTargetablePositions,
and so we must guarantee that Created has been called for
the ITargetablePositions traits first.

@pchote pchote added this to the Next Release milestone Feb 4, 2019

@IceReaper
Copy link
Contributor

IceReaper left a comment

Fixes the problem on my side :)

@pchote pchote added the PR: Needs +2 label Feb 6, 2019

@matjaeck
Copy link
Contributor

matjaeck left a comment

Bug and fix confirmed.

@pchote pchote merged commit 95dc9cb into OpenRA:bleed Feb 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-frozenactor-init-crash branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment