New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache passenger bounty traits. #16175

Merged
merged 1 commit into from Feb 9, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Feb 6, 2019

Supersedes #16136.

@pchote pchote added this to the Next Release milestone Feb 6, 2019

@pchote pchote referenced this pull request Feb 6, 2019

Closed

Fix a crash in GivesBounty #16136

@pchote pchote force-pushed the pchote:bounty-trait-caching branch from 7b0e280 to 6f7d9ce Feb 6, 2019

Cache passenger bounty traits.
This avoids querying from potentially dead actors.

@pchote pchote force-pushed the pchote:bounty-trait-caching branch from 6f7d9ce to 8c0deca Feb 6, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

pchote commented Feb 6, 2019

Updated as discussed in IRC.

@reaperrr

This comment has been minimized.

Copy link
Contributor

reaperrr commented Feb 8, 2019

When the passengers have a valid GivesBounty stance but the transport has not, the passenger bounty is added to player cash but not displayed (no floating text), but as discussed on IRC fixing that would require too much of a rewrite.

Other than that it works fine, so 👍

@obrakmann obrakmann merged commit f9cf45e into OpenRA:bleed Feb 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

obrakmann commented Feb 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment