Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also trigger mission fail when subpen is sold #16177

Merged
merged 1 commit into from Mar 21, 2019

Conversation

@digitalheir
Copy link
Contributor

commented Feb 7, 2019

@pchote pchote added this to the Next Release milestone Feb 7, 2019

@digitalheir

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

Is it better to trigger the check OnRemovedFromWorld than on both OnKilled and OnSold?

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Is it better to trigger the check OnRemovedFromWorld than on both OnKilled and OnSold?

Capturing temporarily removes the actor from the world (or used to, and I doubt that changed in the recent rewrite), so we would have to be careful with OnRemovedFromWorld. OnKilled and OnSold should be good enough.

@pchote

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Trigger.OnSold doesn't seem to exist ingame (script fails immediately on start), or on https://github.com/OpenRA/OpenRA/wiki/Lua-API. The backend code exists for selling and sold triggers, but this doesn't appear to be exposed to Lua, so I really don't know what is going on there.

@digitalheir

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2019

Oops. I found it through C# code so I assumed that it existed. Do you know of any equivalents?

Is it difficult to expose OnSold?

@pchote

This comment has been minimized.

Copy link
Member

commented Feb 8, 2019

The best and simplest fix is to finish adding the half-defined triggers, but this will likely push it outside of the Next Release timescale - aiming for the next and hopefully final playtest this weekend.

@pchote pchote removed the PR: For stable label Feb 8, 2019

@pchote pchote removed this from the Next Release milestone Feb 8, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Depends on #16300 now.

@abcdefg30

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

#16300 was merged.

@reaperrr reaperrr merged commit 040f071 into OpenRA:bleed Mar 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.