Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-placed frozen actors not being targetable #16194

Merged
merged 1 commit into from Feb 20, 2019

Conversation

Projects
None yet
2 participants
@obrakmann
Copy link
Contributor

obrakmann commented Feb 10, 2019

Fixes #16190

@obrakmann obrakmann added this to the Next Release milestone Feb 10, 2019

@@ -126,6 +115,17 @@ void ITick.Tick(Actor self)
if (self.Disposed)
return;

// Defer updating the frozen actor until we are sure that the
// actor's ITargetablePositions traits have been initialized
if (!created && startsRevealed)

This comment has been minimized.

@pchote

pchote Feb 10, 2019

Member

We can probably merge these two bools into a single revealOnFirstTick

This comment has been minimized.

@obrakmann

obrakmann Feb 10, 2019

Author Contributor

Are you sure about that? created gets checked in OnVisibilityChanged by itself. Not sure if it would still do the right thing if those were merged.

This comment has been minimized.

@pchote

pchote Feb 10, 2019

Member

I wasn't sure, so I guess not.

@obrakmann obrakmann force-pushed the obrakmann:fix16190_untargetable-frozen-actors branch from c4c8c7a to e62eadb Feb 10, 2019

@obrakmann obrakmann force-pushed the obrakmann:fix16190_untargetable-frozen-actors branch from e62eadb to 5ef22c9 Feb 10, 2019

@pchote

pchote approved these changes Feb 20, 2019

@pchote pchote merged commit 6841da2 into OpenRA:bleed Feb 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.