Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WithRangeCircle conditional #16223

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Feb 20, 2019

Something long overdue, has been done in generals-alpha-engine long time ago.

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

This is probably better than what I did, please do the same for RenderShroudCircle so I can kill #16147.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2019

Does WSC really need to be conditional? Disabling the Creates/RevealsShroud should disable the circle too already.

@matjaeck

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

Not sure, I think I've tested it and it didn't but very possible that I'm wrong.

@pchote
pchote approved these changes Mar 9, 2019

@pchote pchote added the PR: Needs +2 label Mar 9, 2019

@reaperrr reaperrr merged commit b8a8509 into OpenRA:bleed Mar 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:conditional-with-range-circle branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.