Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Harvester>BaleUnloadAmount #16226

Merged
merged 1 commit into from Mar 9, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Feb 21, 2019

Altho it is no longer using the Harvester/Refinery/Resource logic, i added this to Generals Alpha at the point it did. So everything was dropped off the collectors at once.

Testcase makes RA Harvester drop all 20 bales it has at once.

@reaperrr
Copy link
Contributor

left a comment

Looks good to me

OpenRA.Mods.Common/Traits/Harvester.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/Harvester.cs Outdated Show resolved Hide resolved

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:harvester-unload-amount branch from 36538a6 to cea634d Feb 23, 2019

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:harvester-unload-amount branch from cea634d to aeda796 Feb 23, 2019

@ZxGanon

This comment has been minimized.

Copy link

commented Mar 3, 2019

I tested it ingame and it works fine. (also tested it multiple hours when playing Generals Alpha)

Only problem would be that Ore Trucks in RA1 dont play their complete animation when dumping.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Only problem would be that Ore Trucks in RA1 dont play their complete animation when dumping.

That's just the test-case, or rather how our docking animation is set up.
Not this PR's fault.

👍 after test case is removed.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:harvester-unload-amount branch from aeda796 to f1ee8c6 Mar 8, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Removed the testcase.

@pchote
pchote approved these changes Mar 9, 2019

@pchote pchote merged commit 0b0b82b into OpenRA:bleed Mar 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:harvester-unload-amount branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.