Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a boolean to show or not Refund X$ on the tooltip while selling. #16227

Merged
merged 2 commits into from Feb 22, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Feb 21, 2019

This logic don't have a check for wether of not if you are gonna get any cash out of it, so if the unit worts nothing (like GLA holes in my case) it shows Refund 0$. I added this boolean to not show it for the Holes.

I didn't really wanna add a check for 0$, because it makes sense to show that if the actor is valued but it is so damaged that it won't give anything back.

Also added descriptions for stuff in Sellable that didn't have one.

@reaperrr
Copy link
Contributor

left a comment

I see no harm in adding this, so 👍

@pchote
pchote approved these changes Feb 22, 2019

@pchote pchote merged commit 7049f68 into OpenRA:bleed Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:sellable-text-bool branch Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.