Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExperienceTrickler trait #16228

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Feb 21, 2019

In Generals Alpha i use this for Hackers which gains experience when they are deployed to hack. Basically cash trickler, but gives unit XP.

Testcase allows you to deploy the rifle infantry and they'll start gaining XP.

@Inq8

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2019

In conjunction with GrantConditionOnAttack, it would be possible to grant veterancy to support units in the official mods with this trait I presume? (Medic/Mechanic)

@pchote
Copy link
Member

left a comment

A couple of minor nits, otherwise LGTM.

OpenRA.Mods.Common/Traits/ExperienceTrickler.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/ExperienceTrickler.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Traits/ExperienceTrickler.cs Outdated Show resolved Hide resolved

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:experience-trickler branch from f272b32 to e951c2a Mar 9, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

👍 after testcase is removed.

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:experience-trickler branch from e951c2a to 4676b27 Mar 10, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Removed the testcase.

@reaperrr reaperrr merged commit 1a728ee into OpenRA:bleed Mar 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:experience-trickler branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.