Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around ChildActivity cancellation issues in AttackLeap #16236

Merged
merged 1 commit into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@pchote
Copy link
Member

pchote commented Feb 23, 2019

This PR implements the workaround mentioned in #16191. Note that this is targeted at prep-1901 directly, not bleed. #16217 will fix the issue properly for Next + 1.

Remove ChildActivity from LeapAttack.
Temporary workaround for cancellation issues when
child activities use the Move activity.

@pchote pchote added this to the Next Release milestone Feb 23, 2019

@chrisforbes

This comment has been minimized.

Copy link
Member

chrisforbes commented Feb 23, 2019

LGTM as short term w/a

@pchote pchote added the PR: Needs +2 label Feb 23, 2019

@reaperrr reaperrr merged commit ceff7ae into OpenRA:prep-1901 Feb 24, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@pchote pchote deleted the pchote:fix-attackleap-childactivities branch Feb 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.