Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in soviet05 #16238

Merged
merged 1 commit into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Feb 23, 2019

Fixes #16204.

Any objections if I remove the ObjectiveMet sound (in a follow-up)? We are not consistently playing it on all missions and it overlaps with the capture notification (we could delay that one instead, though).

@pchote pchote added this to the Next Release milestone Feb 24, 2019

@@ -144,7 +144,10 @@ end
Tick = function()
if Greece.HasNoRequiredUnits() and GoodGuy.HasNoRequiredUnits() then
player.MarkCompletedObjective(KillAll)
player.MarkCompletedObjective(HoldObjective)

if HoldObjective then

This comment has been minimized.

@reaperrr

reaperrr Feb 24, 2019

Contributor

Since I'm not so good with our lua scripts and couldn't find the info in our code:
How exactly does this check work? Do objectives return a boolean value, or does this just check if it's not null?

This comment has been minimized.

@abcdefg30

abcdefg30 Feb 24, 2019

Author Member

Check if it the variable is not null (or true, but it won't be true).

@pchote

pchote approved these changes Mar 1, 2019

Copy link
Member

pchote left a comment

As mentioned in IRC, I don't really like how you can end up with two different sets of primary objectives depending on how you complete the mission. It would be better if it granted and then immediately completed the hold objective instead.

Otherwise, 👍 and I don't think this should block the playtest so merging as-is.

@pchote pchote merged commit 7f3c527 into OpenRA:bleed Mar 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:cap05 branch Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.