Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StyleCheck.exe.config #16248

Merged
merged 2 commits into from Mar 7, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Feb 28, 2019

Since #16196, this was automatically created on compile every time (on Windows, at least).

That's quite annoying on bleed. Adding it to the repo directly should fix the original issue without that side-effect from #16196.

@pchote

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

The Game and Utility exes have config files committed to the repository, so wouldn't it make more sense for this too?

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

I don't know how differently things are treated on Linux/macOS, so I'm not sure. If we do add this config to the main folder, we probably have to revert #16196.

@reaperrr reaperrr force-pushed the reaperrr:ignore-config branch from ed1a4c9 to 42260e6 Mar 3, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 3, 2019

Updated. @portablestew @GraionDilach can you confirm that this works, too?

@reaperrr reaperrr changed the title Make git ignore StyleCheck.exe config Add StyleCheck.exe.config Mar 3, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Confirmed that #14013 stays fixed on this PR, at least for me.

@pchote pchote added the PR: Needs +2 label Mar 5, 2019

@pchote
pchote approved these changes Mar 5, 2019
@portablestew

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Confirm that I can still "make check" on this branch, after building with MonoDevelop.

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

I can't check this - the original bug was limited to my Travis tests only - https://travis-ci.org/AttacqueSuperior/Engine/builds/254123577 - and I still haven't got there to even reapply #13611 myself.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

I'll take @portablestew's confirmation as +2, lgtm.

@reaperrr reaperrr merged commit 2c311a8 into OpenRA:bleed Mar 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@reaperrr reaperrr deleted the reaperrr:ignore-config branch Apr 4, 2019

@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

Can confirm that did managed to fix it. Better late than never.

https://travis-ci.org/AttacqueSuperior/Engine/builds/528098701

@pchote

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Just in time for it to be removed completely as part of #14182 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.