Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement our own Png writer and remove System.Drawing dependency #16272

Merged
merged 2 commits into from Mar 14, 2019

Conversation

@pchote
Copy link
Member

commented Mar 5, 2019

This PR removes our last internal System.Drawing dependency by implementing our own managed png writer.

Closes #15972
Works towards #15955 (removes last uses from our code, but SharpFont still uses it 馃槩)

Testcases:

  • Save a map in the map editor (32 bit png)
  • Use the --png utility command (indexed png)
  • Use the --png-sheet-import and --png-sheet-export commands (embedded data)

@pchote pchote added this to the Next + 1 milestone Mar 5, 2019

@pchote pchote requested a review from chrisforbes Mar 5, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented Mar 5, 2019

Unfortunately we aren't quite rid of System.Drawing - we're going to need to fork and remove it from SharpFont too.

@abcdefg30
Copy link
Member

left a comment

Looks good to me. Map previews and utility commands work, too.

bitmap.UnlockBits(bd);
}
}
header.WriteByte(0); // Compression

This comment has been minimized.

Copy link
@chrisforbes

chrisforbes Mar 13, 2019

Member

No compression?

@reaperrr reaperrr merged commit 2a9721a into OpenRA:bleed Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:diy-png-saving branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.