Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NuGet-related dependency fetching on Windows #16276

Merged
merged 2 commits into from Mar 7, 2019

Conversation

@penev92
Copy link
Member

commented Mar 7, 2019

Noticed a couple of issues today after make clean on Windows.
The dependency fetching script somehow was downloading an ancient version of NuGet (2.8.6 vs the currently latest 4.9.3), which was refusing to work.
After that it turned out that NuGet breaks if you have alternative (private, for example) feeds set up and one of them isn't responding.

You can test the alternative feed issue by adding a dummy entry in %AppData%\NuGet\NuGet.Config (Windows) or ~/.nuget/NuGet/NuGet.Config (Mac/Linux). Just add

<add key="DummyFeed" value="http://openra.org/nuget" />

and try running make dependencies.
I do fully expect to have to apply this fix for Linux/MacOS as well.

penev92 added 2 commits Mar 7, 2019
Changed NuGet download link for the Windows dependencies script
The previous link downloaded a very old version of nuget.exe for some reason.
Explicitly specified NuGet package source in the Windows dependencies…
… script

Otherwise NuGet breaks there are alternative (private) NuGet feeds set up on the local machine and one of them isn't responding currently.

@penev92 penev92 requested review from abcdefg30 and MustaphaTR Mar 7, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

I do fully expect to have to apply this fix for Linux/MacOS as well.

We download the nuget packages directly using curl or wget, so nothing to change there.

@penev92

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Wow, dodged that bullet for once! :D

@abcdefg30
Copy link
Member

left a comment

I can't reproduce your problem, but the changes look good to me.

@abcdefg30 abcdefg30 requested a review from reaperrr Mar 7, 2019

@reaperrr reaperrr merged commit ffac21c into OpenRA:bleed Mar 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.