Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bogus and unnecessary Color[] FieldLoader override. #16286

Merged
merged 1 commit into from Mar 12, 2019

Conversation

@pchote
Copy link
Member

commented Mar 9, 2019

Fixes #16285.

This code has always been wrong, but was never used because HSLColor did not define a corresponding array override. The default array parsing works fine for Color, so we can remove this override completely.

@pchote pchote added this to the Next + 1 milestone Mar 9, 2019

@abcdefg30 abcdefg30 merged commit 71b61ad into OpenRA:bleed Mar 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

@pchote pchote deleted the pchote:fix-fieldloader-crash branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.