Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid target crash in SupportPowerManager.Activate. #16288

Merged
merged 1 commit into from Mar 10, 2019

Conversation

@pchote
Copy link
Member

commented Mar 9, 2019

Fixes #16287.

@pchote pchote added this to the Next + 1 milestone Mar 9, 2019

@fusion809

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

This PR works for me. This file (OpenRA-Red-Alert-25777-pr-16288-appimages-replay.zip) I'm attaching is a zip archive containing:

  • A Red Alert AppImage (OpenRA-Red-Alert-25777-without-patch-x86_64.AppImage) built from commit 25777 (b8a8509) that exhibits this bug.
  • A Red Alert AppImage (OpenRA-Red-Alert-25777-pr-16288-patch-applied-x86_64.AppImage) built from commit 25777 (b8a8509), with the patch this PR provides applied.
  • A replay (OpenRA-2019-03-10T034944Z.orarep) that, when run under OpenRA-Red-Alert-25777-without-patch-x86_64.AppImage, produces the crash described in #16287.

Providing this to make it easier for others to reproduce the bug, try the fix provided by this PR and thereby verify that it works.

@MustaphaTR
Copy link
Member

left a comment

Didn't test the GPS but applying the changes locally fixes the same crash happening with SpawnActorPower for Satellite Scan in RV.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

In my opinion that's enough to count as 2nd +1.

@reaperrr reaperrr merged commit 71dd84b into OpenRA:bleed Mar 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pchote pchote deleted the pchote:fix-gps-crash branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.