Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent support powers from creating two camera actors #16304

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
5 participants
@abcdefg30
Copy link
Member

abcdefg30 commented Mar 12, 2019

Closes #16137.

Case from the replay:

  • Plane a enters the zone, sees no planes in the zone, creates a camera
  • Plane a dies, because not all planes are dead yet the current camera is not removed
  • Plane b enters the zone, sees no planes in it, creates a new camera overwriting the reference to the old
  • Only the new camera gets removed, the old one stays

@abcdefg30 abcdefg30 added this to the Next + 1 milestone Mar 12, 2019

@dragunoff

This comment has been minimized.

Copy link
Contributor

dragunoff commented Mar 14, 2019

Why not add this to Next release? IMO it's a glaring bug.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 14, 2019

The next release is finished as of a few days ago and is just waiting on all the related admin work to be finished before tagging. This isn't a serious enough bug to risk delaying or introducing regressions.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Mar 14, 2019

The next release is finished as of a few days ago and is just waiting on all the related admin work to be finished before tagging.

This is an argument for fixing it now since there is some time left and no tag yet. The fix looks not dangerous and the bug can be game(play) breaking. It also is a regression. Please reconsider this.

@pchote

This comment has been minimized.

Copy link
Member

pchote commented Mar 14, 2019

@abcdefg30 mentioned in IRC that this is a very old bug, and not a recent regression.

@matjaeck

This comment has been minimized.

Copy link
Contributor

matjaeck commented Mar 14, 2019

I can reproduce this in the playtest but not in last release.

Only the new camera gets removed, the old one stays

To me it looks before 9be7298#diff-400b4816a5998a2a279d11fb17e31b41L107 the initially created camera would have been removed because if (!aircraftInRange.Any(kv => kv.Value)) would have been true in onEnterRange and onExitRange which (if I read it correctly) was bound to onRemovedFromWorld.

Plane a dies, because not all planes are dead yet the current camera is not removed

In any case this wouldn't be relevant in last release because it only checked for range.

@pchote

pchote approved these changes Mar 14, 2019

@matjaeck
Copy link
Contributor

matjaeck left a comment

Tested only in RA.

@pchote pchote merged commit a332527 into OpenRA:bleed Mar 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:dupCam branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.