Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA - Fix Veterancy removal on shellmap rules. #16314

Merged
merged 3 commits into from Mar 30, 2019

Conversation

@MustaphaTR
Copy link
Member

commented Mar 16, 2019

Since we moved GainsExperience inheritance from defaults to units, the current implementation on RA shellmap causes crashes if a unit without GainsExperience kills something somehow (i.e Crushing).

D2k Shellmap seems to be already set up this way.

@MustaphaTR MustaphaTR changed the title Fix Veterancy removal on shellmap rules. RA - Fix Veterancy removal on shellmap rules. Mar 16, 2019

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:shellmap-veterancy-fix branch from 65a47a3 to 12f8f58 Mar 16, 2019

@MustaphaTR MustaphaTR force-pushed the MustaphaTR:shellmap-veterancy-fix branch from 12f8f58 to 792bdbf Mar 16, 2019

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 16, 2019

I tryed to use wall change as a workaround for the yaml merging issue but it didn't work for travis even tho worked for me locally. But i'm gonna keep it, i still think walls on the shellmap should be indestructible.

@obrakmann
Copy link
Contributor

left a comment

Works as advertised. Could I ask you to fix the TS shellmap as well?

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

TS Shellmap doesn't seem to have Veterancy removal at all do you want me to add it?

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

@MustaphaTR Yes, please do.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

I think we want the invulnerable walls on the TS shellmap, too.
👍 after that.

@MustaphaTR

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2019

Looking at the TS Shellmap, i feel like it needs way more work. Can we merge this as currently is and i do some further work on TS Shellmap in seperate PR?

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Alright, in that case lgtm.

@reaperrr reaperrr merged commit 7fe2d12 into OpenRA:bleed Mar 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MustaphaTR MustaphaTR deleted the MustaphaTR:shellmap-veterancy-fix branch Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.