Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add a time limit lobby option and Lua API #16317
3 times, most recently
Apr 20, 2019
Two final polish nits, then LGTM feature-wise.
We'll also need to disable or remove the time limit from the scripted maps / minigames where it doesn't make sense, but i'm okay with this being deferred to a followup PR if you don't have the time or interest to do it here.
I'll file a separate PR to tweak the option bins layout so that we can fit all the default options without scrolling (it is just possible).
abcdefg30 left a comment
A few other minor nits (only really need to fix the last one, but the others are nice to have):
IMO this is fine, because its almost never going to happen.