Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SequenceActivities with ChildActivity in several activities. #16348

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@tovl
Copy link
Contributor

commented Mar 23, 2019

This replaces all remaining self-referential uses of SequenceActivities with childactivities for all activities except for the aircraft activities.

@pchote pchote requested a review from obrakmann Mar 23, 2019

@obrakmann
Copy link
Contributor

left a comment

Just a couple of comments, code looks good otherwise. Haven't playtested yet.

OpenRA.Mods.Cnc/Traits/Attack/AttackTesla.cs Outdated Show resolved Hide resolved

@tovl tovl force-pushed the tovl:refactor-activities branch from 87915eb to 3048f93 Mar 23, 2019

@obrakmann
Copy link
Contributor

left a comment

Looks good to me otherwise, 👍

@tovl tovl force-pushed the tovl:refactor-activities branch from 3048f93 to 71a0b7e Mar 25, 2019

@pchote
pchote approved these changes Mar 25, 2019
Copy link
Member

left a comment

LGTM and didn't spot any obvious regressions ingame 👍

@pchote pchote merged commit 30de4df into OpenRA:bleed Mar 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pchote pchote referenced this pull request Mar 26, 2019

@tovl tovl deleted the tovl:refactor-activities branch Mar 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.