Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor modifiers in multitap detection #16351

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@ubitux
Copy link
Contributor

commented Mar 24, 2019

Fixes Issue #15577.

@pchote
Copy link
Member

left a comment

Looks reasonable to me, just one minor style nit to suggest:

OpenRA.Platforms.Default/MultiTapDetection.cs Outdated Show resolved Hide resolved

@ubitux ubitux force-pushed the ubitux:multitap-with-mods branch from fcc46df to f08562a Mar 24, 2019

@pchote
pchote approved these changes Mar 24, 2019

@pchote pchote added the PR: Needs +2 label Mar 24, 2019

@obrakmann obrakmann merged commit 3b926d7 into OpenRA:bleed Mar 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@obrakmann

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.