Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement D2k Death Hand & TS Cluster Missile warheads #16363

Merged
merged 5 commits into from May 9, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Mar 29, 2019

Replaced those "normal nukes with different label" with proper cluster warhead and weapons.

@reaperrr reaperrr referenced this pull request Mar 29, 2019
1 of 2 tasks complete
@GraionDilach

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

Impressive idea on the D2k spread.

mods/d2k/weapons/debris.yaml Outdated Show resolved Hide resolved
mods/d2k/weapons/other.yaml Outdated Show resolved Hide resolved
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Updated.

  • Changed warhead targeting of 'x' cells to be completely random, instead of only firing at those cells in a random order
  • Fixed RandomClusterCount to actually fire all clusters even if exceeding the number of 'x' cells
  • tweaked both the DeathHand and ClusterMissile, including their damage (was way too low before, especially on the DH compared to Atreides airstrike).
@ltem

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

Hi,
the PR causes the game to crash if the Air Strike ability of the Atreides is selected (clicked on it).

Exception Log
OpenRA engine version {DEV_VERSION}
Dune 2000 mod version {DEV_VERSION}
on map 06be8293c93b69169596dbc26b8b01718ab1b55d (Habbanya Erg by Westwood Studios).
Date: 2019-04-12 08:48:08Z
Operating System: Linux (Unix 4.9.0.6)
Runtime Version: Mono 5.20.1.19 (tarball Thu Apr 11 09:07:22 UTC 2019) CLR 4.0.30319.42000
Exception of type `System.NullReferenceException`: Object reference not set to an instance of an object
  at OpenRA.Graphics.Animation..ctor (OpenRA.World world, System.String name, System.Func`1[TResult] facingFunc, System.Func`1[TResult] paused) [0x00041] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Graphics.Animation..ctor (OpenRA.World world, System.String name, System.Func`1[TResult] facingFunc) [0x00000] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Graphics.Animation..ctor (OpenRA.World world, System.String name) [0x00000] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Mods.Common.Traits.SelectDirectionalTarget..ctor (OpenRA.World world, System.String order, OpenRA.Mods.Common.Traits.SupportPowerManager manager, System.String cursor, System.String targetPlaceholderCursorAnimation, System.String directionArrowAnimation) [0x00068] in <ffb3ab30e4fa4867a23165aa4828e1d6>:0 
  at OpenRA.Mods.Common.Traits.AirstrikePower.SelectTarget (OpenRA.Actor self, System.String order, OpenRA.Mods.Common.Traits.SupportPowerManager manager) [0x00063] in <ffb3ab30e4fa4867a23165aa4828e1d6>:0 
  at OpenRA.Mods.Common.Traits.SupportPowerInstance.Target () [0x00038] in <ffb3ab30e4fa4867a23165aa4828e1d6>:0 
  at OpenRA.Mods.Common.Widgets.SupportPowersWidget.ClickIcon (OpenRA.Mods.Common.Widgets.SupportPowersWidget+SupportPowerIcon clicked) [0x000a1] in <ffb3ab30e4fa4867a23165aa4828e1d6>:0 
  at OpenRA.Mods.Common.Widgets.SupportPowersWidget.HandleMouseInput (OpenRA.MouseInput mi) [0x000b8] in <ffb3ab30e4fa4867a23165aa4828e1d6>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x0009d] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Widget.HandleMouseInputOuter (OpenRA.MouseInput mi) [0x00051] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Widgets.Ui.HandleInput (OpenRA.MouseInput mi) [0x00030] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.DefaultInputHandler+<>c__DisplayClass5_0.<OnMouseInput>b__0 () [0x00000] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Sync.RunUnsynced[T] (System.Boolean checkSyncHash, OpenRA.World world, System.Func`1[TResult] fn) [0x00023] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.DefaultInputHandler.OnMouseInput (OpenRA.MouseInput input) [0x0000d] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Platforms.Default.Sdl2Input.PumpInput (OpenRA.Platforms.Default.Sdl2PlatformWindow device, OpenRA.IInputHandler inputHandler) [0x0014e] in <814709d0a3f34d14abcf0893eebcc6e3>:0 
  at OpenRA.Platforms.Default.Sdl2PlatformWindow.PumpInput (OpenRA.IInputHandler inputHandler) [0x00006] in <814709d0a3f34d14abcf0893eebcc6e3>:0 
  at OpenRA.Renderer.EndFrame (OpenRA.IInputHandler inputHandler) [0x0000c] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Game.RenderTick () [0x00126] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Game.Loop () [0x0010f] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Game.Run () [0x0003c] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Game.InitializeAndRun (System.String[] args) [0x00010] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
  at OpenRA.Program.Main (System.String[] args) [0x00044] in <b83846feb5de4a5d9e4502bd4f16b18e>:0 
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

That's a regression from the airstrike direction PR, ping @teinarss.

@reaperrr reaperrr referenced this pull request Apr 12, 2019
@teinarss

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

That's a regression from the airstrike direction PR, ping @teinarss.

Will fix it this weekend!

@pchote

This comment has been minimized.

Copy link
Member

commented Apr 14, 2019

https://youtu.be/dmflM70vtZI?t=350 shows that the death hand missile doesn't actually detonate to generate the clusters, but instead spawns them before impacting the ground itself.

It also has a cool trail effect that we're still missing. #16399

OpenRA.Mods.Common/Warheads/FireClusterWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/FireClusterWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/FireClusterWarhead.cs Outdated Show resolved Hide resolved
OpenRA.Mods.Common/Warheads/FireClusterWarhead.cs Outdated Show resolved Hide resolved
Spread: 1c0
Falloff: 200, 100, 50, 25, 12, 0
Damage: 27000 ##225 in vanilla but of course is a cluster bomb instead, so damage spread out
Damage: 4500

This comment has been minimized.

Copy link
@pchote

pchote Apr 14, 2019

Member

tweaked both the DeathHand and ClusterMissile, including their damage (was way too low before, especially on the DH compared to Atreides airstrike).

Do you mean relative to the original game, or relative to common sense?

This comment has been minimized.

Copy link
@reaperrr

reaperrr Apr 14, 2019

Author Contributor

Both. TS Cluster Missile was normally a guaranteed kill for at least up to Advanced Power Plants in the original, provided they were on the targeted cell.

Death Hand in the original had some inherent Missile inaccuracy, but when it hit something directly, it hit pretty hard.
Additionally, Ornithopters in our mod are more powerful than in the original, and actually feel a tiny bit more powerful than the DH even with this.
But to be honest, I'd prefer to leave any further D2k balance polishing to someone like @MustaphaTR, this was just to make the difference between the super weapons small enough that it doesn't make the DH a joke in comparison.

mods/d2k/weapons/other.yaml Outdated Show resolved Hide resolved
@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Rebased & updated.

@reaperrr reaperrr force-pushed the reaperrr:ClusterWH branch from c169b59 to b55de70 Apr 22, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Updated.

@reaperrr reaperrr force-pushed the reaperrr:ClusterWH branch 2 times, most recently from 9a355d0 to 7fbfb13 Apr 22, 2019

@reaperrr reaperrr force-pushed the reaperrr:ClusterWH branch from 7fbfb13 to 16bc5c7 May 4, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

Updated.

@reaperrr reaperrr force-pushed the reaperrr:ClusterWH branch from 16bc5c7 to e559211 May 4, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

Updated. Did a quick test and DeathHand still works, while TS cluster missile now correctly considers terrain height.

@pchote pchote added the PR: Needs +2 label May 4, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 5, 2019

Getting the updated DeathHand into the playtest would be nice, adding to milestone.

@reaperrr reaperrr added this to the Next Release milestone May 5, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Looks like the launch of the cluster is a bit off? Not sure how it was in the original.

cluster

@pchote

This comment has been minimized.

Copy link
Member

commented May 8, 2019

Also looks like its missing a launch delay to let the doors open before firing.

Needs a rebase.

GraionDilach and others added 5 commits Jul 8, 2018
Add DetonationAltitude to NukePower
And RemoveMissileOnDetonation boolean.

Allows airburst, and optionally missile continuing
until it hits the ground (without a second explosion).

@reaperrr reaperrr force-pushed the reaperrr:ClusterWH branch from e559211 to 4c43db9 May 9, 2019

@reaperrr reaperrr removed the PR: Rebase me! label May 9, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Rebased, fixed offset and launch delay.

@pchote
pchote approved these changes May 9, 2019

@pchote pchote merged commit 17a4009 into OpenRA:bleed May 9, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.