Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SequenceActivities with ChildActivity in several air activities. #16364

Merged
merged 1 commit into from Mar 30, 2019

Conversation

@tovl
Copy link
Contributor

commented Mar 30, 2019

Two more rather trivial activity refactors to get rid of SequenceActivities(..., this). This leaves only FlyAttack, but that one is a bit more involved (It should probably be remodeled after AttackFollows), so let's get this out of the way first.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2019

ResupplyAircraft will be another offender after #16321 is merged, but that will be fixed relatively quickly by #16352, I just wanted to mention it for the sake of completeness.

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Mar 30, 2019

I don't consider that one an offender, because it doesn't refer to this. It's still cleaner without SequenceActivities at all, but I consider this a legitimate use. The problems only arise when a single activity gets 'recycled' in the activity queue.

@pchote
pchote approved these changes Mar 30, 2019

@pchote pchote merged commit 8ee1102 into OpenRA:bleed Mar 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.