Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pseudo-childactivities in several activities. #16379

Merged
merged 2 commits into from Apr 20, 2019

Conversation

@tovl
Copy link
Contributor

commented Apr 2, 2019

Continuing the work of #16374 this PR replaces pseudo-childactivites by actual usage of Childactivity in Enter and related activities as well as in the WaitForTransport activity. I also made some slight simplifications in the Enter activity. The only pseudo-childactivities remaining now are in AttackMoveActivity, which would need to be based on #16369 to work properly on aircraft.

@matjaeck
Copy link
Contributor

left a comment

Ingame testing didn't reveal any regressions in RA.

@pchote
pchote approved these changes Apr 20, 2019
Copy link
Member

left a comment

Code changes LGTM and didn't notice any issues ingame.

@pchote pchote added the PR: Needs +2 label Apr 20, 2019

@pchote

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Taking @matjaeck's testing as a second 👍

@pchote pchote merged commit 6aea91b into OpenRA:bleed Apr 20, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.