Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mobile.CurrentMovementType vertical handling #16385

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@reaperrr
Copy link
Contributor

commented Apr 4, 2019

Fixes #16384.

@reaperrr reaperrr added this to the Next Release milestone Apr 4, 2019

@pchote pchote added the PR: Needs +2 label Apr 14, 2019

Fix Mobile.CurrentMovementType vertical handling
On bleed, the Horizontal flag is always returned on any position change,
even if that change is vertical-only.

@reaperrr reaperrr force-pushed the reaperrr:fix-notifymove branch from 63b89cb to 52d2297 Apr 14, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Updated.

@reaperrr

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@abcdefg30 @matjaeck Can one of you confirm the fix?

@matjaeck
Copy link
Contributor

left a comment

I tested this already but apparently forgot to submit the review. Tested again, can confirm the bug and fix.

@reaperrr reaperrr merged commit 5f6c8ba into OpenRA:bleed Apr 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.