Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in FindAndDeliverResources.GetSearchFromLocation. #16387

Merged
merged 1 commit into from Apr 13, 2019

Conversation

@tovl
Copy link
Contributor

commented Apr 5, 2019

Let GetSearchFromLocation check whether the refinery is dead first. Hopefully this fixes #16386.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

Wouldn't an additional IsInWorld check be better, in case the refinery got sold in the meantime?

@tovl tovl force-pushed the tovl:fixharvestercrash branch from a2d5fb4 to b044171 Apr 6, 2019

@tovl

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

Added the extra check.

fusion809 added a commit to fusion809/openra-git that referenced this pull request Apr 7, 2019
@fusion809

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

Just played an RA game on Arch with this PR applied and it didn't crash, so it seems like you may have fixed this.

@reaperrr reaperrr merged commit 2a942bd into OpenRA:bleed Apr 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.