Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sound.Play overloads that play a random sound from a list #16391

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@abcdefg30
Copy link
Member

commented Apr 7, 2019

Following a discussion on IRC.

OpenRA.Game/Sound/Sound.cs Outdated Show resolved Hide resolved

@abcdefg30 abcdefg30 force-pushed the abcdefg30:playSounds branch from a9669d4 to 4c07906 Apr 14, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Apr 14, 2019

Updated.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

This breaks at least weapon firing sounds.

@abcdefg30 abcdefg30 force-pushed the abcdefg30:playSounds branch from 4c07906 to 31661d5 Apr 18, 2019

@abcdefg30

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Ah I see what you mean, they were more quiet than usual because I passed the wrong bool for distance calculation. Should be fixed.

@reaperrr reaperrr merged commit 1bb3194 into OpenRA:bleed Apr 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@abcdefg30 abcdefg30 deleted the abcdefg30:playSounds branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.