Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix EngineerRepair stances and make the trait more customisable. #16407
Engineer Repair stances didn't work for 2 reasons. In the order generator it was not actually checking info.ValidStances, but directly if the target is Ally or not. 2 the Stance check in the activity was wrong way around.
This PR in addition to that:
TESTCASE is only for stance fix. I didn't set up for anything else.
pchote left a comment
I assume you already know about the conflict between this and capturing, and that it doesn't matter for your usecase here.
Code changes look reasonable and this doesn't appear to regress anything in the default mods, so LGTM.
I'm assuming of course that the testcase will be removed before merging.