Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectDirectionalTarget fixes #16414

Merged
merged 3 commits into from Apr 22, 2019

Conversation

@teinarss
Copy link
Contributor

commented Apr 14, 2019

Closes #16402
Closes #16413

Also fixes the problem with the support power button and reverts the hack in RA that was made previous.

@teinarss teinarss force-pushed the teinarss:selectdirection_fixes branch 2 times, most recently from 9b5e35c to efe7caa Apr 20, 2019

@teinarss teinarss force-pushed the teinarss:selectdirection_fixes branch from efe7caa to af57f5b Apr 20, 2019

@teinarss teinarss force-pushed the teinarss:selectdirection_fixes branch from af57f5b to e0bd502 Apr 21, 2019

@pchote
pchote approved these changes Apr 22, 2019

@pchote pchote added the PR: Needs +2 label Apr 22, 2019

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

The circle beacon anim doesn't loop.
👍 after that's fixed or if it's not a regression from this PR.

@reaperrr

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

OK, that's not a regression from this PR, LGTM.

@reaperrr reaperrr merged commit e801537 into OpenRA:bleed Apr 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.