Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA1 verification to package downloads #16491

Merged
merged 2 commits into from Jun 8, 2019

Conversation

@pchote
Copy link
Member

commented May 4, 2019

This PR makes sure that the downloaded files contain the data that we expect before extracting them to disk.

I have verified that all the existing mirrors host valid files.

@pchote pchote added this to the Next Release milestone May 4, 2019

@teinarss

This comment has been minimized.

Copy link
Contributor

commented May 18, 2019

Looks good except that the error text doesn't fit.
image

@pchote pchote force-pushed the pchote:download-integrity branch from 0e99bea to 2bdf325 May 18, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented May 18, 2019

Updated:

Screenshot 2019-05-18 at 14 31 31

@pchote

This comment has been minimized.

Copy link
Member Author

commented May 25, 2019

@teinarss can you confirm a 👍 with the new wording?

@teinarss

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@pchote pchote force-pushed the pchote:download-integrity branch from 2bdf325 to c584ba4 May 31, 2019

@pchote

This comment has been minimized.

Copy link
Member Author

commented May 31, 2019

Updated wording as discussed in IRC.

@pchote pchote added the PR: Needs +2 label May 31, 2019

@abcdefg30 abcdefg30 merged commit 1aa80f9 into OpenRA:bleed Jun 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abcdefg30

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@pchote pchote deleted the pchote:download-integrity branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.