Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Hovers defaults as well as some potential crashes #16496
The problem is that without the clamping, some of the bugs trigger even on values that don't look suspicious at all at first glance, because the diff between InitialHeight and OffsetModifier plays into that, too (in addition to the tick values).
All in all and considering how Hover Tanks worked in original TS, I'm beginning to think this trait isn't really suited to alter the visual 'center position' of hovering actors.
That said, unless you feel like taking over and reviewing + fixing the traits' math properly, it's basically 'take as-is' (except for minor fixes, if necessary) or revert the PR that introduced those issues, though that would also lose us some functionality again.
abcdefg30 left a comment
You are changing a bunch of default values as it looks. Are we fine with not having an update rule? (I actually assume yes as you labelled those default changes as bugfixes.)